linux-kernel - Re: [patch 3/3] speakup: add unicode variant of /dev/softsynth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 03 Mar 2017 10:40:11 -0800
From:   Chris Brannon <chris@...-brannons.com>
To:     Samuel Thibault <samuel.thibault@...-lyon.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kirk Reiser <kirk@...sers.ca>,
        William Hubbs <w.d.hubbs@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        speakup@...ux-speakup.org
Subject: Re: [patch 3/3] speakup: add unicode variant of /dev/softsynth

Samuel Thibault <samuel.thibault@...-lyon.org> writes:

> This adds /dev/softsynthu, along /dev/softsynth, which emits output in
> UTF-8 encoding, thus allowing to support 16bit characters.  Most of the
> code is shared, only the read function has to behave differently in
> latin1 and in unicode mode.  Since Linux only supports 16bit characters,
> we can just hardcode the UTF-8 encoding.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>


Reviewed-by: Chris Brannon <chris@...-brannons.com>

Looks good to me.