linux-kernel - Re: [PATCH] fs/pstore: constify pstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKFMvbV7KR-=G8qPJZao7yHoYbhZahoSNrsxiufuSi69A@mail.gmail.com>
Date:   Fri, 3 Mar 2017 11:41:06 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     Julia Lawall <julia.lawall@...6.fr>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/pstore: constify pstore_zbackend structures

On Sun, Feb 19, 2017 at 1:37 AM, Bhumika Goyal <bhumirks@...il.com> wrote:
> The references of pstore_zbackend structures are stored into the
> pointer zbackend of type struct pstore_zbackend. The pointer zbackend
> can be made const as it is only dereferenced. After making this change
> the pstore_zbackend structures whose references are stored into the
> pointer zbackend can be made const too.
>
> File size before:
>    text    data     bss     dec     hex filename
>    4817     541     172    5530    159a fs/pstore/platform.o
>
> File size after:
>    text    data     bss     dec     hex filename
>    4865     477     172    5514    158a fs/pstore/platform.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Awesome, thanks! I've applied this to my tree; it should be visible in
-next soon.

-Kees

-- 
Kees Cook
Pixel Security