linux-kernel - Re: [PATCH 0/8] Droid4 DTS update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170304162655.GZ20572@atomide.com>
Date:   Sat, 4 Mar 2017 08:26:55 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Sebastian Reichel <sre@...nel.org>
Cc:     Benoît Cousson <bcousson@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] Droid4 DTS update

* Tony Lindgren <tony@...mide.com> [170303 08:31]:
> * Sebastian Reichel <sre@...nel.org> [170303 03:03]:
> > On Wed, Mar 01, 2017 at 05:49:11PM -0800, Tony Lindgren wrote:
> > > Some of the command mode LCD patches could be sent out too, and
> > > if the timing patch is OK then we can configure the LCD in the dts
> > > too. Have you had a chance to look at those related to what all I
> > > broke for n950?
> > 
> > I took your patchset and fixed it for N950. The main problem was,
> > that you dropped the fifo size update, which is required for OMAP3
> > (HW bug). Here is a branch based on recent master branch from
> > torvalds. I had a quick test with droid4 and dmesg still looked fine,
> > but I did not have the lm3532 patches in that branch and nothing is
> > visible without display backlight. Can you check if the branch works
> > for you on D4?
> 
> OK good to hear you figured it out. Yeah I tried to cut down the
> changes to minimum to get some idea what's going on and noticed I did
> not need the fifo changes for droid 4. I'll take a look later on today
> or over the weekend.

I tested your branch and those patches work just fine on droid 4.

I did not test the fifo patch as it's missing something compiles
as loadable modules:

ERROR: "dispc_ovl_set_fifo_threshold" [drivers/gpu/drm/omapdrm/omapdrm.ko] undefined!
ERROR: "dispc_ovl_compute_fifo_thresholds" [drivers/gpu/drm/omapdrm/omapdrm.ko] undefined!

Probably just EXPORT_SYMBOL missing?

Anyways, yeah I guess that set is pretty much ready to be sent for
review if you feel like sending it. Or let me know if you want me to
send it.

Regards,

Tony


> > http://git.kernel.org/cgit/linux/kernel/git/sre/linux-n900.git/log/?h=n950-display-tony