linux-kernel - Re: [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bmtfx2cr.fsf@belgarion.home>
Date:   Sun, 05 Mar 2017 14:47:00 +0100
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Philippe Reynes <tremyfr@...il.com>
Cc:     nico@...xnic.net, davem@...emloft.net, mugunthanvnm@...com,
        jarod@...hat.com, felipe.balbi@...ux.intel.com,
        rmk+kernel@...linux.org.uk, fw@...len.de, jeremy.linton@....com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

Philippe Reynes <tremyfr@...il.com> writes:

> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes <tremyfr@...il.com>
> ---
> Changelog:
> v2:
> - also update comment (feeback from Russel King)

Ok, I tested it, with :
    ethtool -s eth0 duplex half autoneg off speed 10
    ethtool eth0
       => see the changes
    ping -f x.x.x.x
    ethtool -s eth0 duplex full autoneg on
    ethtool eth0
       => see the changes
    ping -f x.x.x.x

This both with your patch and without, it works in both cases, and the former as
a smaller throughput, which makes me believe the patch is fine.

Tested-by: Robert Jarzmik <robert.jarzmik@...e.fr>

Cheers.

--
Robert