linux-kernel - Re: [PATCH v3 0/3] Add support for MyGica T230C DVB-T2 stick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170306083408.5abb44b5@vento.lan>
Date:   Mon, 6 Mar 2017 08:34:13 -0300
From:   Mauro Carvalho Chehab <mchehab@...pensource.com>
To:     Antti Palosaari <crope@....fi>
Cc:     "Brüns, Stefan" <Stefan.Bruens@...h-aachen.de>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>
Subject: Re: [PATCH v3 0/3] Add support for MyGica T230C DVB-T2 stick

Em Sat, 4 Mar 2017 03:23:42 +0200
Antti Palosaari <crope@....fi> escreveu:

> On 03/03/2017 08:35 PM, Brüns, Stefan wrote:
> > On Fr, 2017-02-17 at 01:55 +0100, Stefan Brüns wrote:  
> >> The required command sequence for the new tuner (Si2141) was traced
> >> from the
> >> current Windows driver and verified with a small python
> >> script/libusb.
> >> The changes to the Si2168 and dvbsky driver are mostly additions of
> >> the
> >> required IDs and some glue code.
> >>
> >> Stefan Brüns (3):
> >>   [media] si2157: Add support for Si2141-A10
> >>   [media] si2168: add support for Si2168-D60
> >>   [media] dvbsky: MyGica T230C support
> >>
> >>  drivers/media/dvb-core/dvb-usb-ids.h      |  1 +
> >>  drivers/media/dvb-frontends/si2168.c      |  4 ++
> >>  drivers/media/dvb-frontends/si2168_priv.h |  2 +
> >>  drivers/media/tuners/si2157.c             | 23 +++++++-
> >>  drivers/media/tuners/si2157_priv.h        |  2 +
> >>  drivers/media/usb/dvb-usb-v2/dvbsky.c     | 88
> >> +++++++++++++++++++++++++++++++
> >>  6 files changed, 118 insertions(+), 2 deletions(-)  
> >
> > Instead of this series, a different patchset was accepted, although
> > Antti raised concerns about at least 2 of the 3 patches accpeted, more
> > specifically the si2157 patch contains some bogus initialization code,

Sorry, I likely missed those comments when reviewed the patch series.

As the applied series won't cause regressions, as all init code seem
specific to the new tuner, I won't be reverting the patchsets, but
wait for Antti to be able to do a deeper look on it.

Please submit a patch removing the bogus init code, for Antti's
review.

> > and the T230C support were better added to the dvbsky driver instead of
> >  cxusb.  

IMHO, the better here would be to merge both drivers into one, as they
seem to be doing very similar stuff. So, I can't find a good reason
why we should keep both drivers upstream. As dvbsky uses dvb-usb-v2,
the best would be to move the board-specific code from cxusb into
the dvbsky driver, and drop the cxusb driver.

Feel free to submit such patch too.

> Patch set looks good. I ordered that device and it arrived yesterday. I 
> will handle that during 2 weeks - it is now skiing holiday and I am at 
> France alps whole next week. So just wait :)

Regards,

Thanks,
Mauro