linux-kernel - Re: [PATCH 0/2] HID: Corsair Scimitar Pro RGB gaming mouse driver and support for other Corsair devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Mar 2017 13:55:21 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Oscar Campos <oscar.campos@...ber.fsf.org>
cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] HID: Corsair Scimitar Pro RGB gaming mouse driver
 and support for other Corsair devices

On Fri, 10 Feb 2017, Oscar Campos wrote:

> Since I have a Corsair Scimitar PRO RGB that does not works on Linux, I
> tried to find a solution doing some research but was not able to find any.
[ ... snip ... ]
> 
> I created the new mouse driver instead of add code to the already existent
> `hid-corsair.c` as it seem quite common to split mouse and keyboard driver
> support.

Hi Oscar,

thanks a lot for the patch.

Keeping the support in hid-corsair would be prefered. I think the only 
driver where we have the major kbd/mouse split is Holtek, which if I 
remember correctly was my fault not having catched this during review; it 
should probably eventually be unified.

Otherwsie, we don't really distinguish the device type (the HID land is 
much wider than mice and keyboards anyway), but in most cases by the 
vendor.

Could you please resubmit the patch so that it's actually adding changes 
to hid-corsair? Thanks!

-- 
Jiri Kosina
SUSE Labs