linux-kernel - Re: [PATCH] staging: speakup: else is not generally useful after a break or return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201703062042.2wJkZ1BS%fengguang.wu@intel.com>
Date:   Mon, 6 Mar 2017 20:59:13 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
Cc:     kbuild-all@...org, w.d.hubbs@...il.com, devel@...verdev.osuosl.org,
        Kirk Reiser <kirk@...sers.ca>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        speakup@...ux-speakup.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        Chris Brannon <chris@...-brannons.com>
Subject: Re: [PATCH] staging: speakup: else is not generally useful after a
 break or return

Hi Arushi,

[auto build test WARNING on staging/staging-testing]
[cannot apply to v4.11-rc1 next-20170306]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Arushi-Singhal/staging-speakup-else-is-not-generally-useful-after-a-break-or-return/20170306-072009
config: openrisc-allmodconfig (attached as .config)
compiler: or32-linux-gcc (GCC) 4.5.1-or32-1.0rc1
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=openrisc 

All warnings (new ones prefixed by >>):

   drivers/staging/speakup/keyhelp.c: In function 'spk_handle_help':
>> drivers/staging/speakup/keyhelp.c:146:19: warning: unused variable 'val'
>> drivers/staging/speakup/keyhelp.c:146:11: warning: unused variable 'p_keys'
>> drivers/staging/speakup/keyhelp.c:145:9: warning: unused variable 'func'
>> drivers/staging/speakup/keyhelp.c:143:9: warning: unused variable 'n'

vim +/val +146 drivers/staging/speakup/keyhelp.c

c6e3fd22c William Hubbs   2010-10-07  137  	}
c6e3fd22c William Hubbs   2010-10-07  138  	return 0;
c6e3fd22c William Hubbs   2010-10-07  139  }
c6e3fd22c William Hubbs   2010-10-07  140  
ca2beaf84 Samuel Thibault 2013-01-02  141  int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key)
c6e3fd22c William Hubbs   2010-10-07  142  {
c6e3fd22c William Hubbs   2010-10-07 @143  	int i, n;
c6e3fd22c William Hubbs   2010-10-07  144  	char *name;
c6e3fd22c William Hubbs   2010-10-07 @145  	u_char func, *kp;
c6e3fd22c William Hubbs   2010-10-07 @146  	u_short *p_keys, val;
8e69a8110 Domagoj Trsan   2014-09-09  147  
c6e3fd22c William Hubbs   2010-10-07  148  	if (letter_offsets[0] == -1)
c6e3fd22c William Hubbs   2010-10-07  149  		help_init();

:::::: The code at line 146 was first introduced by commit
:::::: c6e3fd22cd538365bfeb82997d5b89562e077d42 Staging: add speakup to the staging directory

:::::: TO: William Hubbs <w.d.hubbs@...il.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...e.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (40416 bytes)