linux-kernel - Re: [PATCH] HID: usbhid: Use pr_<level> and remove unnecessary OOM messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1703061440490.31814@cbobk.fhfr.pm>
Date:   Mon, 6 Mar 2017 14:40:58 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Joe Perches <joe@...ches.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-usb@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: usbhid: Use pr_<level> and remove unnecessary OOM
 messages

On Wed, 1 Mar 2017, Joe Perches wrote:

> Use a more common logging style and remove the unnecessary
> OOM messages as there is default dump_stack when OOM.
> 
> Miscellanea:
> 
> o Hoist an assignment in an if
> o Realign arguments
> o Realign a deeply indented if descendent above a printk
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied to for-4.12/upstream. Thanks,

-- 
Jiri Kosina
SUSE Labs