linux-kernel - Re: [PATCH v10 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fb60ffc-086f-9e68-137a-a8aa1411ba40@osg.samsung.com>
Date:   Mon, 6 Mar 2017 11:42:04 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Hoegeun Kwon <hoegeun.kwon@...sung.com>, thierry.reding@...il.com,
        airlied@...ux.ie, robh+dt@...nel.org, mark.rutland@....com,
        catalin.marinas@....com, will.deacon@....com, kgene@...nel.org,
        krzk@...nel.org
Cc:     dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        inki.dae@...sung.com, a.hajda@...sung.com, cw00.choi@...sung.com,
        jh80.chung@...sung.com, andi.shyti@...sung.com
Subject: Re: [PATCH v10 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel
 device on TM2 board

Hello Hoegeun,

On 02/21/2017 10:09 PM, Hoegeun Kwon wrote:
> From: Hyungwon Hwang <human.hwang@...sung.com>
> 
> This patch add the panel device tree node for S6E3HA2 display
> controller to TM2 dts.
> 
> Signed-off-by: Hyungwon Hwang <human.hwang@...sung.com>
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@...sung.com>
> Tested-by: Chanwoo Choi <cw00.choi@...sung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> index dea0a6f..db3fed2 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> @@ -52,6 +52,18 @@
>      assigned-clock-rates = <250000000>, <400000000>;
>  };

I would add a line here.

>  +&dsi {
> +    panel@0 {
> +        compatible = "samsung,s6e3ha2";
> +        reg = <0>;
> +        vdd3-supply = <&ldo27_reg>;
> +        vci-supply = <&ldo28_reg>;
> +        reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
> +        enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
> +        te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
> +    };
> +};
> +

Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America