linux-kernel - Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170306133958.GY7064@mail.corp.redhat.com>
Date:   Mon, 6 Mar 2017 14:39:58 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Bastien Nocera <hadess@...ess.net>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Peter Hutterer <peter.hutterer@...-t.net>,
        Nestor Lopez Casado <nlopezcasad@...itech.com>,
        Olivier Gay <ogay@...itech.com>,
        Simon Wood <simon@...gewell.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in
 power_supply

On Mar 06 2017 or thereabouts, Bastien Nocera wrote:
> On Mon, 2017-03-06 at 13:18 +0100, Jiri Kosina wrote:
> > On Tue, 7 Feb 2017, Benjamin Tissoires wrote:
> > 
> > > > > +               case POWER_SUPPLY_PROP_MANUFACTURER:
> > > > > +                       val->strval = "Logitech, Inc.";
> > > > 
> > > > I don't like this change. I'd prefer the concatenated
> > > > manufacturer and
> > > > model strings leading to user-friendly strings, and "Logitech
> > > > T650" is
> > > > better than "Logitech, Inc. T650".
> > > 
> > > Is this the only problematic issue? We are at rc7 already so I
> > > would
> > > like to have the final version ready ASAP.
> > 
> > Bastien, do you have any input on the rest of the series please?
> 
> My comment about "[PATCH 04/15] HID: logitech-hidpp: battery: remove
> overloads and provide ONLINE" is the blocker.
> 
> No particular comments about the rest of the series.

Yes, sorry, this is still on my plate. I'll send out a revised series
soon hopefully.

Cheers,
Benjamin