linux-kernel - Re: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99270126-7751-eed0-5efa-fc695ff3be25@oracle.com>
Date:   Mon, 6 Mar 2017 11:58:59 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Elena Reshetova <elena.reshetova@...el.com>,
        gregkh@...uxfoundation.org
Cc:     peterz@...radead.org, linux-pci@...r.kernel.org,
        target-devel@...r.kernel.org,
        linux1394-devel@...ts.sourceforge.net, devel@...verdev.osuosl.org,
        linux-s390@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-serial@...r.kernel.org, fcoe-devel@...n-fcoe.org,
        xen-devel@...ts.xenproject.org, open-iscsi@...glegroups.com,
        linux-media@...r.kernel.org, Kees Cook <keescook@...omium.org>,
        linux-raid@...r.kernel.org, linux-bcache@...r.kernel.org,
        Hans Liljestrand <ishkamiel@...il.com>,
        David Windsor <dwindsor@...il.com>, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        devel@...uxdriverproject.org, Juergen Gross <jgross@...e.com>
Subject: Re: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users
 from atomic_t to refcount_t

On 03/06/2017 09:21 AM, Elena Reshetova wrote:
> refcount_t type and corresponding API should be
> used instead of atomic_t when the variable is used as
> a reference counter. This allows to avoid accidental
> refcounter overflows that might lead to use-after-free
> situations.
>
> Signed-off-by: Elena Reshetova <elena.reshetova@...el.com>
> Signed-off-by: Hans Liljestrand <ishkamiel@...il.com>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: David Windsor <dwindsor@...il.com>
> ---
>  drivers/xen/gntdev.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>