linux-kernel - Re: [PATCH 1/2] mm: use is_migrate_highatomic() to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170306124318.e88843a07c76584bee7689e2@linux-foundation.org>
Date:   Mon, 6 Mar 2017 12:43:18 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     Xishi Qiu <qiuxishi@...wei.com>, Vlastimil Babka <vbabka@...e.cz>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Minchan Kim <minchan@...nel.org>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Yisheng Xie <xieyisheng1@...wei.com>,
        Linux MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mm: use is_migrate_highatomic() to simplify the
 code

On Mon, 6 Mar 2017 14:38:33 +0100 Michal Hocko <mhocko@...nel.org> wrote:

> On Fri 03-03-17 15:06:19, Andrew Morton wrote:
> > On Fri, 3 Mar 2017 14:18:08 +0100 Michal Hocko <mhocko@...nel.org> wrote:
> > 
> > > On Fri 03-03-17 19:10:13, Xishi Qiu wrote:
> > > > Introduce two helpers, is_migrate_highatomic() and is_migrate_highatomic_page().
> > > > Simplify the code, no functional changes.
> > > 
> > > static inline helpers would be nicer than macros
> > 
> > Always.
> > 
> > We made a big dependency mess in mmzone.h.  internal.h works.
> 
> Just too bad we have three different header files for
> is_migrate_isolate{_page} - include/linux/page-isolation.h
> is_migrate_cma{_page} - include/linux/mmzone.h
> is_migrate_highatomic{_page} - mm/internal.h
> 
> I guess we want all of them in internal.h?

I suppose so.  arch/powerpc/mm/mmu_context_iommu.c is using
is_migrate_cma_page which would need some attention.