linux-kernel - Re: [PATCH 2/3] percpu: acquire pcpu_lock when updating pcpu_nr_empty_pop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170306205612.GF26127@htj.duckdns.org>
Date:   Mon, 6 Mar 2017 15:56:12 -0500
From:   Tejun Heo <tj@...nel.org>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Christoph Lameter <cl@...ux.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Roman Pen <r.peniaev@...il.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Michal Hocko <mhocko@...e.com>, zijun_hu <zijun_hu@....com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] percpu: acquire pcpu_lock when updating
 pcpu_nr_empty_pop_pages

On Sat, Feb 25, 2017 at 01:00:19PM -0800, Tahsin Erdogan wrote:
> Update to pcpu_nr_empty_pop_pages in pcpu_alloc() is currently done
> without holding pcpu_lock. This can lead to bad updates to the variable.
> Add missing lock calls.
> 
> Fixes: b539b87fed37 ("percpu: implmeent pcpu_nr_empty_pop_pages and chunk->nr_populated")
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>

Applied to percpu/for-4.11-fixes w/ stable cc'd.

Thanks.

-- 
tejun