linux-kernel - Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170307072322.GB29708@gmail.com>
Date:   Tue, 7 Mar 2017 08:23:22 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     kbuild test robot <fengguang.wu@...el.com>
Cc:     Rik van Riel <riel@...hat.com>, kbuild-all@...org,
        linux-kernel@...r.kernel.org, tipbuild@...or.com,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>, Borislav Petkov <bp@...e.de>
Subject: Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings


* kbuild test robot <fengguang.wu@...el.com> wrote:

> arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function 'xfeatures_mxcsr_quirk' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.

Note that this is a totally bogus warning. I personally find a 0/1 return more 
readable than a textual 'true/false', even if bools are used, and nowhere does the 
kernel mandate the use of 0/1.

So NAK ...

Thanks,

	Ingo