linux-kernel - Re: [PATCH 03/10] perf, tools: Factor out PMU matching in parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170307100300.GB12093@krava>
Date:   Tue, 7 Mar 2017 11:03:00 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     acme@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 03/10] perf, tools: Factor out PMU matching in parser

On Tue, Feb 28, 2017 at 10:49:17PM -0800, Andi Kleen wrote:

SNIP

> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index a14b47ab3879..6b2bc918fc94 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -236,37 +236,9 @@ PE_NAME opt_event_config
>  |
>  PE_KERNEL_PMU_EVENT sep_dc
>  {
> -	struct parse_events_evlist *data = _data;
> -	struct list_head *head;
> -	struct parse_events_term *term;
>  	struct list_head *list;
> -	struct perf_pmu *pmu = NULL;
> -	int ok = 0;
>  
> -	/* Add it for all PMUs that support the alias */
> -	ALLOC_LIST(list);
> -	while ((pmu = perf_pmu__scan(pmu)) != NULL) {
> -		struct perf_pmu_alias *alias;
> -
> -		list_for_each_entry(alias, &pmu->aliases, list) {
> -			if (!strcasecmp(alias->name, $1)) {
> -				ALLOC_LIST(head);
> -				ABORT_ON(parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_USER,
> -					$1, 1, &@1, NULL));
> -				list_add_tail(&term->list, head);

http://marc.info/?l=linux-kernel&m=148818456131560&w=2

jirka