linux-kernel - RE: [PATCH] staging: unisys: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Mar 2017 12:45:51 +0000
From:   "Kershner, David A" <David.Kershner@...sys.com>
To:     Andrea Ghittino <aghittino@...il.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        *S-Par-Maintainer <SParMaintainer@...sys.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] staging: unisys: fix sparse warnings



> -----Original Message-----
> From: Andrea Ghittino [mailto:aghittino@...il.com]
> Sent: Saturday, March 4, 2017 12:21 PM
> To: devel@...verdev.osuosl.org; Kershner, David A
> <David.Kershner@...sys.com>; gregkh@...uxfoundation.org; *S-Par-
> Maintainer <SParMaintainer@...sys.com>; linux-kernel@...r.kernel.org
> Subject: [PATCH] staging: unisys: fix sparse warnings
> 
> Sparse generates two warnings related to incorrect type in assignment.
> This patch changes the types in the struct defined in unisys
> 
> Signed-off-by: Andrea Ghittino <aghittino@...il.com>

Acked-by: David Kershner <david.kershner@...sys.com>

Tested it on s-Par and no problems. 

> ---
> Compile tested only
> 
>  iochannel.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/unisys/include/iochannel.h
> b/drivers/staging/unisys/include/iochannel.h
> index 54f4900..41e5b4e 100644
> --- a/drivers/staging/unisys/include/iochannel.h
> +++ b/drivers/staging/unisys/include/iochannel.h
> @@ -308,8 +308,8 @@ struct net_pkt_xmt {
>  		u8 valid;	/* 1 = struct is valid - else ignore */
>  		u8 hrawoffv;	/* 1 = hwrafoff is valid */
>  		u8 nhrawoffv;	/* 1 = nhwrafoff is valid */
> -		u16 protocol;	/* specifies packet protocol */
> -		u32 csum;	/* value used to set skb->csum at IOPart */
> +		__be16 protocol;	/* specifies packet protocol */
> +		__wsum csum;	/* value used to set skb->csum at IOPart */
>  		u32 hrawoff;	/* value used to set skb->h.raw at IOPart */
>  		/* hrawoff points to the start of the TRANSPORT LAYER
> HEADER */
>  		u32 nhrawoff;	/* value used to set skb->nh.raw at IOPart */