linux-kernel - About boot time Tux logo with -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Mar 2017 01:24:11 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Laurent <laurent.pinchart@...asonboard.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Fabian Frederick <fabf@...net.be>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     shimoda <yoshihiro.shimoda.uh@...esas.com>,
        <koji.matsuoka.xm@...esas.com>,
        shiiba <naoya.shiiba.nx@...esas.com>,
        sakato <ryusuke.sakato.bx@...esas.com>,
        Hosoya <yoshifumi.hosoya.wj@...esas.com>,
        Fukawa <tomoharu.fukawa.eb@...esas.com>,
        <hien.dang.eb@...esas.com>, <khiem.nguyen.xt@...esas.com>,
        <kouei.abe.cp@...esas.com>, <harunobu.kurokawa.dn@...esas.com>,
        <hiroyuki.yokoyama.vx@...esas.com>,
        <takeshi.kihara.df@...esas.com>, <linux-fbdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: About boot time Tux logo with -EPROBE_DEFER


Hi

I want to ask you about boot time Tux logo.

For some reasons, current our video driver returns -EPROBE_DEFER when
probe timing, but logo init function doesn't care it.
Thus, our kernel can't have logo when boot time.

I think this is not only our issue, but general issue ?

Thus, I think logo init function should care about -EPROBE_DEFER
or something. In our quick hack, this issue was solved by below patch,
but I don't know this is OK.

So, how to solve this issue ? do you have nice idea ?
or can maintainer accept below patch ?

-------------------
diff --git a/drivers/video/logo/logo.c b/drivers/video/logo/logo.c
index b6bc4a0bda2a..4d50bfd13e7c 100644
--- a/drivers/video/logo/logo.c
+++ b/drivers/video/logo/logo.c
@@ -34,7 +34,7 @@ static int __init fb_logo_late_init(void)
     return 0;
 }

-late_initcall(fb_logo_late_init);
+late_initcall_sync(fb_logo_late_init);

 /* logo's are marked __initdata. Use __ref to tell
  * modpost that it is intended that this function uses data
-------------------

Best regards
---
Kuninori Morimoto