linux-kernel - Re: [PATCH 2/3] ASoC: dio2125: add dio2125 amp driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170307135548.hienxpgghn4ztanw@sirena.org.uk>
Date:   Tue, 7 Mar 2017 14:55:48 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Jerome Brunet <jbrunet@...libre.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, Kevin Hilman <khilman@...libre.com>,
        Neil Armstrong <narmstrong@...libre.com>
Subject: Re: [PATCH 2/3] ASoC: dio2125: add dio2125 amp driver

On Tue, Mar 07, 2017 at 02:13:20PM +0100, Jerome Brunet wrote:

> Indeed, Thanks for pointing this out.
> I have question regarding this DAPM control.
> Here, I put the control in DAPM so it can help with the pop noise
> reduction, but I think it would be nice if the user could force the
> mute if he wants to.

> Would it be OK to add a user control and some logic so the output is
> enabled only if DAPM and the user agree it should ?

You should be able to do something with an autodisable control, or
extend the mechanism to support this.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)