linux-kernel - Re: [tip:x86/asm] x86/asm: Optimize clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Mar 2017 08:30:12 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Yinghai Lu <yinghai@...nel.org>
Cc:     "H. Peter Anvin" <hpa@...or.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        Wu Fengguang <fengguang.wu@...el.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Borislav Petkov <bp@...e.de>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andy Lutomirski <luto@...nel.org>,
        Brian Gerst <brgerst@...il.com>,
        "linux-tip-commits@...r.kernel.org" 
        <linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/asm] x86/asm: Optimize clear_page()


* Yinghai Lu <yinghai@...nel.org> wrote:

> On Wed, Mar 1, 2017 at 1:47 AM, tip-bot for Borislav Petkov
> <tipbot@...or.com> wrote:
> > Commit-ID:  49ca7bb328c630dd43be626534b49e19513296fd
> > Gitweb:     http://git.kernel.org/tip/49ca7bb328c630dd43be626534b49e19513296fd
> > Author:     Borislav Petkov <bp@...e.de>
> > AuthorDate: Thu, 9 Feb 2017 01:34:49 +0100
> > Committer:  Ingo Molnar <mingo@...nel.org>
> > CommitDate: Wed, 1 Mar 2017 10:18:32 +0100
> >
> > x86/asm: Optimize clear_page()
> >
> > Currently, we CALL clear_page() which then JMPs to the proper function
> > chosen by the alternatives.
> >
> > What we should do instead is CALL the proper function directly. (This
> > was something Ingo suggested a while ago). So let's do that.
> 
> looks like this one broke the kexec.
> after revert it back, kexec work again.

Ok, this should be fixed in the new version I just pushed out:

  f25d38475519 x86/asm: Optimize clear_page()

Please let me know if it doesn't.

Thanks,

	Ingo