linux-kernel - Re: [PATCH 02/23] perf buildid-cache: Add -q/--quiet option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170307152830.GB7670@kernel.org>
Date:   Tue, 7 Mar 2017 12:28:30 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, kernel-team@....com
Subject: Re: [PATCH 02/23] perf buildid-cache: Add -q/--quiet option

Em Wed, Mar 08, 2017 at 12:08:30AM +0900, Namhyung Kim escreveu:
> The -q/--quiet option is to suppress any message.  Sometimes users just
> want to run the command and it can be used for that case.

<SNIP>

> +++ b/tools/perf/builtin-buildid-cache.c
> @@ -311,6 +311,7 @@ int cmd_buildid_cache(int argc, const char **argv,
>  	OPT_INCR('v', "verbose", &verbose, "be more verbose"),
> +	OPT_BOOLEAN('q', "quiet", &quiet, "Do not show any message"),
>  	OPT_END()
>  	};
>  	const char * const buildid_cache_usage[] = {
> @@ -326,6 +327,9 @@ int cmd_buildid_cache(int argc, const char **argv,
>  
> +	if (quiet)
> +		perf_quiet_option();
> +

Hey, I see that this is done lots of times, can't we use that parent
option stuff? Or some fallback we can have in perf's main() for thing
like this?

- Arnaldo