linux-kernel - Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Mar 2017 12:36:46 -0500
From:   Mark Stenglein <mark@...ngle.in>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding
 style issue

All,

Thanks for the feedback. Trying to introduce myself and in retrospect
this seems to be a fairly non-productive way to go about it. Apologies
for any time lost.

Best,
Mark Stenglein

On Tue, Mar 07, 2017 at 08:31:13PM +0300, Dan Carpenter wrote:
> On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote:
> > Fixed a coding style issue.
> >
> > Signed-off-by: Mark Stenglein <mark@...ngle.in>
> > ---
> >  drivers/staging/wlan-ng/hfa384x.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> > index 5f1851c85f12..f19984747b1e 100644
> > --- a/drivers/staging/wlan-ng/hfa384x.h
> > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> >  	enum ctlx_state state;	/* Tracks running state */
> >  
> >  	struct completion done;
> > +
> >  	volatile int reapable;	/* Food for the reaper task */
> 
> No blank line needed.  The original is OK.  (Except for the volatile is
> wrong obviously).
> 
> regards,
> dan carpenter
>