lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 07 Mar 2017 12:34:06 -0800 (PST) From: David Miller <davem@...emloft.net> To: Jie.Deng1@...opsys.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v1 net-next] net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet From: Jie Deng <Jie.Deng1@...opsys.com> Date: Wed, 1 Mar 2017 12:00:25 +0800 > +static int xlgmac_init(struct xlgmac_pdata *pdata) > +{ > + struct net_device *netdev = pdata->netdev; > + struct xlgmac_hw_ops *hw_ops = &pdata->hw_ops; Please order local variable declarations from longest to shortest line. Please fix this in your entire submission. > + > +err_netdev_register: > +err_init: Avoid multiple error labels in the same exact location, by having only one which describes what the error path unwinds. For example, here you could say "err_free_netdev". Please fix this up in your entire submission.
Powered by blists - more mailing lists