linux-kernel - Re: [PATCH V3] ARM: dts: exynos5440: support the phy-pcie node for pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170307200545.oxibgmzx6wwc2fay@kozik-lap>
Date:   Tue, 7 Mar 2017 22:05:45 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Jaehoon Chung <jh80.chung@...sung.com>
Cc:     linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        kgene@...nel.org, robh+dt@...nel.org, javier@....samsung.com,
        niyas.ahmed@...sung.com, alim.akhtar@...sung.com,
        pankaj.dubey@...sung.com
Subject: Re: [PATCH V3] ARM: dts: exynos5440: support the phy-pcie node for
 pcie

On Tue, Feb 28, 2017 at 04:00:26PM +0900, Jaehoon Chung wrote:
> Add pcie-phy node for using phy-exynos-pcie.
> 
> There are some modifications.
> 1. Remove the configuration space values in "ranges" property.
> - The getting configuration space from ranges is old way.
> - Instead, It can be got from "config"
> 
> 2. Use the reg-names as "elbi", "config".
> - Can know the purpose of use with reg-names.
> 

Thanks, applied with changes:
1. Proper subject prefix. Please pay attention to that.
2. Re-write of commit message. There were language errors, mixed up
   prepositions. Also a "phy-pcie node" cannot be "supported". You can
   add a node. You cannot support a node.

The quality of commit message is important for maintainability of source
code because eventually it explains the logic behind the changes in the
code.

Best regards,
Krzysztof