linux-kernel - Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Mar 2017 20:24:38 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Andrea Ghittino <aghittino@...il.com>
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        ganesh.krishna@...rochip.com, aditya.shankar@...rochip.com
Subject: Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type
 assignment

On Tue, Mar 07, 2017 at 08:23:04PM +0300, Dan Carpenter wrote:
> This commit doesn't tell me if you though about what you are doing at
> all.  We get so many commits where people just randomly do random endian
> things...  Did you think about this?  Could you resend with a better
> commit message?
> 

The commit message should say what the user visible effects of this
bug fix are going to be.

regards,
dan carpenter