linux-kernel - Re: [PATCH] mtd: spi-nor: intel: use ERR_CAST in return statement

Open Source and information security mailing list archives

Message-ID: <73fac7b3-5791-dd23-289b-339b8c6ce0e0@wedev4u.fr>
Date:   Tue, 7 Mar 2017 22:19:00 +0100
From:   Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Nicholas Mc Guire <der.herr@...r.at>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>,
        linux-mtd@...ts.infradead.org, Richard Weinberger <richard@....at>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        Brian Norris <computersforpeace@...il.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH] mtd: spi-nor: intel: use ERR_CAST in return statement

Le 14/02/2017 à 11:09, Boris Brezillon a écrit :
> On Mon, 13 Feb 2017 09:14:21 +0100
> Nicholas Mc Guire <der.herr@...r.at> wrote:
> 
>> This fixes a sparse warning about incorrect type in retrun expression
> 
> 						      ^return
> 
> and you miss a comma at the end of this sentence.
> 
>>
>> Signed-off-by: Nicholas Mc Guire <der.herr@...r.at>
> 
> You forgot to add my ack (same comment on your other patches).

Applied to spi-nor/next with the following changes:
- fix typo s/retrun/return/ in commit message.
- add missing comma at the end of the sentence.
- add Acked-by tag for Boris.

Thanks!

> 
>> ---
>>
>> V2: fixed prefix and the truncated commit message noted by Boris Brezillon
>>     <boris.brezillon@...e-electrons.com> - thanks!
>>
>> sparse complained about:
>> drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces)
>> drivers/mtd/spi-nor/intel-spi.c:731:28:    expected struct intel_spi *
>> drivers/mtd/spi-nor/intel-spi.c:731:28:    got void [noderef] <asn:2>*base
>>
>> Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
>>
>> Patch is against 4.10-rc7 (localversion-next is next-20170213)
>>
>>  drivers/mtd/spi-nor/intel-spi.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
>> index 2956f2c..1a6de4b 100644
>> --- a/drivers/mtd/spi-nor/intel-spi.c
>> +++ b/drivers/mtd/spi-nor/intel-spi.c
>> @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev,
>>  
>>  	ispi->base = devm_ioremap_resource(dev, mem);
>>  	if (IS_ERR(ispi->base))
>> -		return ispi->base;
>> +		return ERR_CAST(ispi->base);
>>  
>>  	ispi->dev = dev;
>>  	ispi->info = info;
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives