linux-kernel - Re: [PATCH 10/10] Bluetooth: add nokia driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170307230609.kpw3y2pkfka6kgo5@earth>
Date:   Wed, 8 Mar 2017 00:06:09 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Tony Lindgren <tony@...mide.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Mark Rutland <mark.rutland@....com>,
        "open list:BLUETOOTH DRIVERS" <linux-bluetooth@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/10] Bluetooth: add nokia driver

Hi Marcel,

On Tue, Mar 07, 2017 at 10:20:27PM +0100, Marcel Holtmann wrote:
>> [...]
>>
>> - compatible: should contain "nokia,h4p-bluetooth" as well as one of the following:
>> * "brcm,bcm2048-nokia"
>> * "ti,wl1271-blueooth-nokia”
> 
> I never liked the term “h4p”. It is fundamentally just
> “bluetooth”.

It's not me, that came up with the term, Nokia called their protocol
H4+ (for DT people not familiar with bluetooth - the standard
bluetooth UART protocol is named H4). I agree, that H4+ is
ambiguous, but with the "nokia," prefix it should be clear what
protocol is meant. I don't really mind, though. We can also just
list the individual chips and add all compatible strings to the
driver.

FWIW I remove the term from the driver leaving only a single
instance in the header ("AKA H4+").

> What are our plans for Broadcom, Intel etc. Bluetooth UARTs?

I think drivers, that need extra resources (like GPIOs) can switch to
serdev exclusively. The kernel needs ACPI/DT/boardcode data for those
devices anyways.

Iirc Rob is working on serdev patches for Broadcom and TI BT, so he may
provide more information.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)