linux-kernel - Re: [PATCH] dmaengine: rcar-dmac: enable descriptor mode on 40bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874lz47hmt.wl%kuninori.morimoto.gx@renesas.com>
Date:   Wed, 8 Mar 2017 00:13:53 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:     Vinod Koul <vinod.koul@...el.com>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: rcar-dmac: enable descriptor mode on 40bit


Hi Laurent

Thank you for your review

> > +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
> > +			if (i == 0) {
> > +				high_src_addr = chunk->src_addr >> 32;
> > +				high_dst_addr = chunk->dst_addr >> 32;
> > +			}
> 
> This will be triggered for every iteration of the while loop, so if one sg 
> entry crosses a 32-bit boundary, you won't detect it.
> 
> I know it will mean one additional #ifdef, but I think you should move that 
> code out of the while loop as I previously proposed.

Grr indeed. Thank you for pointing it.
Hmm.. OK, I will add +1 #ifdef

Best regards
---
Kuninori Morimoto