linux-kernel - Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681: suspicious mask ?

Open Source and information security mailing list archives

Date:   Wed, 08 Mar 2017 10:01:41 +0100
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     David Binderman <dcb314@...mail.com>,
        "inki.dae@...sung.com" <inki.dae@...sung.com>,
        "jy0922.shim@...sung.com" <jy0922.shim@...sung.com>,
        "sw0312.kim@...sung.com" <sw0312.kim@...sung.com>,
        "kyungmin.park@...sung.com" <kyungmin.park@...sung.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "kgene@...nel.org" <kgene@...nel.org>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "javier@....samsung.com" <javier@....samsung.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681:
 suspicious mask ?

Hi David, Inki,

Thanks for reporting.

On 06.03.2017 11:05, David Binderman wrote:
> Hello there,
>
> linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) Result of operator '|' is always true if one operand is non-zero. Did you intend to use '&'?
>
> Source code is
>
>     if (ctx->out_type | I80_HW_TRG) {
>
> Also in the same file:
>
> [drivers/gpu/drm/exynos/exynos5433_drm_decon.c:131]: (style) Same expression on both sides of '|'.
>
> Source code is
>
>        writel(TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN
>                | TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN,

This typo was already reported by:
- Ilia Mirkin, I have uploaded 2nd fixed version of the patch,
apparently the 1st version has been merged [1],
- Dan Carpenter, he posted also the fix[2],
- and now David.

I guess at the moment the best solution is to get Dan's patch.

[1]: https://patchwork.kernel.org/patch/9493177/
[2]: https://patchwork.kernel.org/patch/9571375/

Regards
Andrzej

>
> Regards
>
> David Binderman
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives