lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Mar 2017 11:39:00 -0800 From: Andi Kleen <ak@...ux.intel.com> To: Davidlohr Bueso <dave@...olabs.net> Cc: akpm@...ux-foundation.org, mhocko@...e.com, mtk.manpages@...il.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org, Davidlohr Bueso <dbueso@...e.de> Subject: Re: [PATCH] mm,hugetlb: compute page_size_log properly > One example of the problems with extra layers what this patch fixes: > mmap_pgoff() should never be using SHM_HUGE_* logic. This was > introduced by: > > 091d0d55b28 (shm: fix null pointer deref when userspace specifies invalid hugepage size) > > It is obviously harmless but lets just rip out the whole thing -- > the shmget.2 manpage will need updating, as it should not be > describing kernel internals. The SHM_* defines were supposed to be exported to user space, but somehow they didn't make it into uapi. But something like this is useful, it's a much nicer interface for users than to hard code the bit position So I would rather if you move it to uapi instead of removing. What the kernel uses internally doesn't really matter. -Andi
Powered by blists - more mailing lists