lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Mar 2017 10:25:59 +0800 From: "Wu, Songjun" <Songjun.Wu@...rochip.com> To: Colin King <colin.king@...onical.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, <linux-media@...r.kernel.org> CC: <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue Hi Colin, Thank you for your comment. It is a bug, will be fixed in the next patch. On 3/7/2017 22:30, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > The are only HIST_ENTRIES worth of entries in hist_entry however the > for-loop is iterating one too many times leasing to a read access off > the end off the array ctrls->hist_entry. Fix this by iterating by > the correct number of times. > > Detected by CoverityScan, CID#1415279 ("Out-of-bounds read") > > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > drivers/media/platform/atmel/atmel-isc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c > index b380a7d..7dacf8c 100644 > --- a/drivers/media/platform/atmel/atmel-isc.c > +++ b/drivers/media/platform/atmel/atmel-isc.c > @@ -1298,7 +1298,7 @@ static void isc_hist_count(struct isc_device *isc) > regmap_bulk_read(regmap, ISC_HIS_ENTRY, hist_entry, HIST_ENTRIES); > > *hist_count = 0; > - for (i = 0; i <= HIST_ENTRIES; i++) > + for (i = 0; i < HIST_ENTRIES; i++) > *hist_count += i * (*hist_entry++); > } > >
Powered by blists - more mailing lists