linux-kernel - Re: [PATCH] phy: phy-exynos-pcie: fix the wrong error return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58C10EBB.1030107@ti.com>
Date:   Thu, 9 Mar 2017 13:43:47 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Jaehoon Chung <jh80.chung@...sung.com>,
        <linux-kernel@...r.kernel.org>
CC:     <krzk@...nel.org>, <kgene@...nel.org>, <javier@....samsung.com>,
        <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH] phy: phy-exynos-pcie: fix the wrong error return



On Wednesday 08 March 2017 01:52 PM, Jaehoon Chung wrote:
> When it doesn't get the blk_base's resource, it was returned
> the error about phy_base, not blk_base.
> This patch is for fixing the wrong error return about blk_base.
> 
> Fixes: cf0adb8e281b ("phy: phy-exynos-pcie: Add support for Exynos PCIe PHY")
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@...sung.com>

merged, thanks.

-Kishon
> ---
>  drivers/phy/phy-exynos-pcie.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/phy-exynos-pcie.c b/drivers/phy/phy-exynos-pcie.c
> index 4f60b83..60baf25 100644
> --- a/drivers/phy/phy-exynos-pcie.c
> +++ b/drivers/phy/phy-exynos-pcie.c
> @@ -254,8 +254,8 @@ static int exynos_pcie_phy_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>  	exynos_phy->blk_base = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(exynos_phy->phy_base))
> -		return PTR_ERR(exynos_phy->phy_base);
> +	if (IS_ERR(exynos_phy->blk_base))
> +		return PTR_ERR(exynos_phy->blk_base);
>  
>  	exynos_phy->drv_data = drv_data;
>  
>