linux-kernel - Re: [PATCH for-4.11] ASoC: don't dereference NULL pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87varjz31k.wl%kuninori.morimoto.gx@renesas.com>
Date:   Thu, 9 Mar 2017 00:53:50 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Brian Norris <briannorris@...omium.org>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        <linux-kernel@...r.kernel.org>, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, <alsa-devel@...a-project.org>
Subject: Re: [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free}


Hi Brian

> > It is a littlle bit strange for me.
> 
> Yes, and honestly I'm a little confused by the inheritance in this
> framework.

Yes, I agree :)
This is 1st prepare for future ALSA SoC framework cleanup
It is Lars-Peter's idea

> I have a feeling you're checking the wrong thing below for this case.

If so, we should fix this "wrong thing" ?

> All I know is that I'm definitely hitting a NULL
> platform->driver->pcm_new callback, and that either reverting your patch
> or applying the patch I just sent fixes it.

I want to know why this happen.
Can you show me which driver is calling snd_soc_add_platform() in your case ?