linux-kernel - Re: [PATCH] dma: xilinx: Make Xilinx VDMA support ARC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1285d07-f925-2c3a-c90c-1ef9ee948b80@synopsys.com>
Date:   Thu, 9 Mar 2017 09:55:59 +0000
From:   Ramiro Oliveira <Ramiro.Oliveira@...opsys.com>
To:     Mike Looijmans <mike.looijmans@...ic.nl>,
        Ramiro Oliveira <Ramiro.Oliveira@...opsys.com>,
        <linux-kernel@...r.kernel.org>, <dmaengine@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     Vinod Koul <vinod.koul@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        <CARLOS.PALMINHA@...opsys.com>
Subject: Re: [PATCH] dma: xilinx: Make Xilinx VDMA support ARC

Hi Mike

On 3/9/2017 7:37 AM, Mike Looijmans wrote:
> On 06-03-17 13:27, Ramiro Oliveira wrote:
>> Add option in Kconfig to use Xilinx VDMA in ARC processors.
>>
>> Signed-off-by: Ramiro Oliveira <roliveir@...opsys.com>
>> ---
>>  drivers/dma/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
>> index 263495d0adbd..b6b6c0581ad7 100644
>> --- a/drivers/dma/Kconfig
>> +++ b/drivers/dma/Kconfig
>> @@ -546,7 +546,7 @@ config XGENE_DMA
>>
>>  config XILINX_DMA
>>      tristate "Xilinx AXI DMAS Engine"
>> -    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
>> +    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64|| ARC)
> 
> One can put a Xilinx FPGA on a PCIe card, instantiate a PCIe-AXI bridge and then
> use it on any platform that supports PCIe.
> 
> I've had to remove this line in order to be able to use the engine on an x86
> desktop.
> 
> How about plainly removing this "depends on" line and be done with it, instead
> of adding platforms one by one?
> 
> 

I agree with you. From my point of view it would be better to remove this line
entirely. I'm just not sure if everyone agrees.

>>      select DMA_ENGINE
>>      help
>>        Enable support for Xilinx AXI VDMA Soft IP.
>>
> 
> 
> 
> Kind regards,
> 
> Mike Looijmans
> System Expert
> 
> TOPIC Products
> Materiaalweg 4, NL-5681 RJ Best
> Postbus 440, NL-5680 AK Best
> Telefoon: +31 (0) 499 33 69 79
> E-mail: mike.looijmans@...icproducts.com
> Website: www.topicproducts.com
> 
> Please consider the environment before printing this e-mail
> 
> 
> 
> 
> 

-- 
Best Regards

Ramiro Oliveira
Ramiro.Oliveira@...opsys.com