linux-kernel - Re: [PATCH] audit: log module name on delete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1703091545020.24778@pobox.suse.cz>
Date:   Thu, 9 Mar 2017 15:49:22 +0100 (CET)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Richard Guy Briggs <rgb@...hat.com>
cc:     linux-kernel@...r.kernel.org, linux-audit@...hat.com,
        Jessica Yu <jeyu@...hat.com>, Eric Paris <eparis@...hat.com>,
        Paul Moore <pmoore@...hat.com>, Steve Grubb <sgrubb@...hat.com>
Subject: Re: [PATCH] audit: log module name on delete_module

On Thu, 9 Mar 2017, Richard Guy Briggs wrote:

> Record the module name of a delete_module call.
> 
> See: https://github.com/linux-audit/audit-kernel/issues/37
> 
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>

Could you improve the changelog, please? I don't think that a link to 
a github issue can and should replace it. Proper description and reason of 
the change should be in git log.

Thanks,
Miroslav

> ---
>  kernel/module.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index 5432dbe..633f6da 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -943,6 +943,8 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
>  		return -EFAULT;
>  	name[MODULE_NAME_LEN-1] = '\0';
>  
> +	audit_log_kern_module(name);
> +
>  	if (mutex_lock_interruptible(&module_mutex) != 0)
>  		return -EINTR;
>  
> -- 
> 1.7.1
>