linux-kernel - Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170309.093851.1057108507009455288.davem@davemloft.net>
Date:   Thu, 09 Mar 2017 09:38:51 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dhowells@...hat.com
Cc:     netdev@...r.kernel.org, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH net] net: Work around lockdep limitation in sockets
 that use sockets

From: David Howells <dhowells@...hat.com>
Date: Thu, 09 Mar 2017 07:51:34 +0000

> David Miller <davem@...emloft.net> wrote:
> 
>> I guess this is fine, but I think you can use one of the two "sk_padding"
>> bits in struct sock instead of making the structure larger.
> 
> It shouldn't make the structure larger since there's a hole in the structure:
 ...
> 		u16			sk_gso_max_segs;
>   ---> 2-byte hole here
> 		unsigned long	        sk_lingertime;
> 
> but I'll quite happily shift it to sk_padding.

Ok, then that's fine.