linux-kernel - Re: [PATCH] platform/x86: dell-laptop: Handle return error form dell_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b91fac9-9c76-24c0-47a3-28a589760725@gmail.com>
Date:   Thu, 9 Mar 2017 11:13:15 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     mjg59@...f.ucam.org, dvhart@...radead.org, andy@...radead.org,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: dell-laptop: Handle return error form
 dell_get_intensity.

Hi,
Yes, you are right. I will handle return error correctly.

Thanks
-Arvind

On Wednesday 08 March 2017 06:24 PM, Pali Rohár wrote:
> Hi!
>
> On Wednesday 08 March 2017 17:52:27 Arvind Yadav wrote:
>> Here, dell_get_intensity can return an error.
> Right. That is truth and we should check for errors.
>
>> So we can assgine props.brightness as max_brightness.
> But why to max_brightness? Seems that this is incorrect handling of
> error too...
>
>> This change is done using Coccinelle.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
>> ---
>>   drivers/platform/x86/dell-laptop.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
>> index f57dd28..0891de3 100644
>> --- a/drivers/platform/x86/dell-laptop.c
>> +++ b/drivers/platform/x86/dell-laptop.c
>> @@ -2053,6 +2053,9 @@ static int __init dell_init(void)
>>   
>>   		dell_backlight_device->props.brightness =
>>   			dell_get_intensity(dell_backlight_device);
>> +		if (dell_backlight_device->props.brightness < 0) {
>> +			dell_backlight_device->props.brightness = props.max_brightness;
>> +		}
>>   		backlight_update_status(dell_backlight_device);
>>   	}
>>