linux-kernel - Re: [PATCH] cpufreq: intel_pstate: Drop redundant wrapper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOh2x==jb5nYaJbebKskJYUf+Y2qQ8agKkcM3gLgoV5A8DNb3Q@mail.gmail.com>
Date:   Fri, 10 Mar 2017 08:46:45 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Linux PM <linux-pm@...r.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: intel_pstate: Drop redundant wrapper function

On Thu, Mar 9, 2017 at 9:00 PM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> intel_pstate_hwp_set_policy() is a wrapper around
> intel_pstate_hwp_set(), but the only value it adds is to check
> hwp_active before calling the latter and one of its two callers
> has already checked hwp_active before that happens, so in that
> code path the additional check is redundant and using the wrapper
> is rather pointless.
>
> For this reason, drop intel_pstate_hwp_set_policy() and make its
> callers invoke intel_pstate_hwp_set() directly (after checking
> hwp_active).
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>  drivers/cpufreq/intel_pstate.c |   18 ++++--------------
>  1 file changed, 4 insertions(+), 14 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>