linux-kernel - Re: [PATCH v3 2/2] usb: gadget: reword configuration choices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2017 09:59:23 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Romain Izard <romain.izard.pro@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v3 2/2] usb: gadget: reword configuration choices

On 03/10/17 05:11, Romain Izard wrote:
> As USB_CONFIGFS is not a part of the "USB Gadget Drivers" choice
> anymore, the name for the option and its attached description needs to
> be more descriptive. It appears one level higher in the configuration
> menu, and without the context provided by the comments for the choice
> entry, it needs to make sense on its own.
> 
> Conversely, the "USB Gadget Drivers" entry now only introduces the
> legacy drivers, where one or more functions are combined in a single
> driver. As the configfs option can be used as a full-fledged
> alternative, rename the choice entry to show that it is not the only
> way to provice service as an USB gadget.
> 
> Signed-off-by: Romain Izard <romain.izard.pro@...il.com>
> ---
> Changes in v3:
>  - split from the functional patch
> 
>  drivers/usb/gadget/Kconfig | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index f3ee80ece682..e157e9aa4f3d 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -212,7 +212,7 @@ config USB_F_TCM
>  # this first set of drivers all depend on bulk-capable hardware.
>  
>  config USB_CONFIGFS
> -	tristate "USB functions configurable through configfs"
> +	tristate "USB Gadget functions configurable through configfs"
>  	select USB_LIBCOMPOSITE
>  	help
>  	  A Linux USB "gadget" can be set up through configfs.
> @@ -458,7 +458,7 @@ config USB_CONFIGFS_F_TCM
>  	  UAS utilizes the USB 3.0 feature called streams support.
>  
>  choice
> -	tristate "USB Gadget Drivers"
> +	tristate "USB Gadget precomposed configurations"
>  	default USB_ETH
>  	optional
>  	help
> @@ -477,6 +477,12 @@ choice
>  	  not be able work with that controller, or might need to implement
>  	  a less common variant of a device class protocol.
>  
> +	  The available choices each represent a single precomposed USB
> +	  gadget configuration. In the device model, each option contains
> +	  both the device instanciation as a child for a USB gadget

	                  instantiation

> +	  controller, and the relevant drivers for each function declared
> +	  by the device.
> +
>  source "drivers/usb/gadget/legacy/Kconfig"
>  
>  endchoice
> 


-- 
~Randy