linux-kernel - Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170310182201.GE21811@dtor-ws>
Date:   Fri, 10 Mar 2017 10:22:01 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, James Hogan <james.hogan@...tec.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        Paul Burton <paul.burton@...tec.com>
Subject: Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel
 entry to OF device ID table

On Fri, Mar 10, 2017 at 10:33:06AM -0300, Javier Martinez Canillas wrote:
> The OF device ID table doesn't have a sentinel NULL entry and so it
> causes the following error:
> 
> FATAL: drivers/auxdisplay/img-ascii-lcd: struct of_device_id is not terminated with a NULL entry!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1
> Makefile:1493: recipe for target 'modules' failed
> make: *** [modules] Error 2
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

This was also causing issues with 0-day builder when driver is built
into the kernel.

> ---
> 
>  drivers/auxdisplay/img-ascii-lcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
> index bf43b5d2aafc..73bc826144d4 100644
> --- a/drivers/auxdisplay/img-ascii-lcd.c
> +++ b/drivers/auxdisplay/img-ascii-lcd.c
> @@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[] = {
>  	{ .compatible = "img,boston-lcd", .data = &boston_config },
>  	{ .compatible = "mti,malta-lcd", .data = &malta_config },
>  	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
> +	{ /* sentinel */ },
>  };
>  
>  /**
> -- 
> 2.9.3
> 

-- 
Dmitry