linux-kernel - Re: [PATCH v3] usb: gadget: udc: remove pointer dereference after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170310152037.Horde.49bdIvAhaWSa41VTBWvs3xO@gator4166.hostgator.com>
Date:   Fri, 10 Mar 2017 15:20:37 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Felipe Balbi <balbi@...nel.org>
Cc:     Michal Nazarewicz <mina86@...a86.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        gregkh@...uxfoundation.org, heikki.krogerus@...ux.intel.com,
        mail@...oabal.eu, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Peter Senna Tschudin <peter.senna@...il.com>
Subject: Re: [PATCH v3] usb: gadget: udc: remove pointer dereference after
 free

Hello,

Quoting Felipe Balbi <balbi@...nel.org>:

> "Gustavo A. R. Silva" <garsilva@...eddedor.com> writes:
>
>> Remove pointer dereference after free.
>>
>> Addresses-Coverity-ID: 1091173
>> Acked-by: Michal Nazarewicz <mina86@...a86.com>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>> ---
>> Changes in v2:
>>   Move pointer dereference before pci_pool_free()
>>   Set pointer to NULL after free
>>
>> Changes in v3:
>>   Remove 'td->next = 0x00' inside for loop.
>>   Remove unnecessary pointer nullification after free.
>>
>>   drivers/usb/gadget/udc/pch_udc.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/udc/pch_udc.c
>> b/drivers/usb/gadget/udc/pch_udc.c
>> index a97da64..8a365aa 100644
>> --- a/drivers/usb/gadget/udc/pch_udc.c
>> +++ b/drivers/usb/gadget/udc/pch_udc.c
>> @@ -1523,7 +1523,6 @@ static void pch_udc_free_dma_chain(struct
>> pch_udc_dev *dev,
>
> line wrapped. Can't apply.
>

I'll fix it right away.

Thanks
--
Gustavo A. R. Silva