linux-kernel - z3fold: suspicious return with spinlock held

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1489180932-13918-1-git-send-email-khoroshilov@ispras.ru>
Date:   Sat, 11 Mar 2017 00:22:12 +0300
From:   Alexey Khoroshilov <khoroshilov@...ras.ru>
To:     Vitaly Wool <vitalywool@...il.com>
Cc:     Alexey Khoroshilov <khoroshilov@...ras.ru>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dan Streetman <ddstreet@...e.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: z3fold: suspicious return with spinlock held

Hello!

z3fold_reclaim_page() contains the only return that may
leave the function with pool->lock spinlock held.

669 	spin_lock(&pool->lock);
670 	if (kref_put(&zhdr->refcount, release_z3fold_page)) {
671 		atomic64_dec(&pool->pages_nr);
672 		return 0;
673 	}

May be we need spin_unlock(&pool->lock); just before return?


Found by Linux Driver Verification project (linuxtesting.org).

--
Thank you,
Alexey Khoroshilov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org