linux-kernel - Re: [PATCH 1/3] audit: auditfilter: remove unnecessary semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2017 17:26:23 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     Nicholas Mc Guire <der.herr@...r.at>
Cc:     Eric Paris <eparis@...hat.com>, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] audit: auditfilter: remove unnecessary semicolon

On Thu, Feb 23, 2017 at 11:24 AM, Nicholas Mc Guire <der.herr@...r.at> wrote:
> The excess ; after the closing parenthesis is just code-noise it has no
> and can be removed.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@...r.at>
> ---
> Problem located by coccinelle
> ./kernel/auditfilter.c:341:2-3: Unneeded semicolon
> ./kernel/auditfilter.c:415:2-3: Unneeded semicolon
>
> Patch was compiletested with: x86_64_defconfig (implies CONFIG_AUDIT )
>
> Patch is against 4.10.0 (localversion-next is next-20170222)
>
>  kernel/auditfilter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Merged.

> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index 880519d..239d11c 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -338,7 +338,7 @@ static int audit_field_valid(struct audit_entry *entry, struct audit_field *f)
>                     entry->rule.listnr != AUDIT_FILTER_USER)
>                         return -EINVAL;
>                 break;
> -       };
> +       }
>
>         switch(f->type) {
>         default:
> @@ -412,7 +412,7 @@ static int audit_field_valid(struct audit_entry *entry, struct audit_field *f)
>                 if (entry->rule.listnr != AUDIT_FILTER_EXIT)
>                         return -EINVAL;
>                 break;
> -       };
> +       }
>         return 0;
>  }
>
> --
> 2.1.4
>



-- 
paul moore
www.paul-moore.com