linux-kernel - Re: [PATCH] Minor coding guideline Fix in lusture module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E7F5CE15-001C-4F6F-B7D5-AEE3650A0B9C@intel.com>
Date:   Fri, 10 Mar 2017 05:25:22 +0000
From:   "Dilger, Andreas" <andreas.dilger@...el.com>
To:     Pushkar Jambhlekar <pushkar.iit@...il.com>
CC:     "Drokin, Oleg" <oleg.drokin@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Hammond, John" <john.hammond@...el.com>,
        "Xiong, Jinshan" <jinshan.xiong@...el.com>,
        lustre-devel <lustre-devel@...ts.lustre.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Minor coding guideline Fix in lusture module

On Mar 9, 2017, at 05:22, Pushkar Jambhlekar <pushkar.iit@...il.com> wrote:
> Subject: Minor coding guideline Fix in lusture module

I suspect the patchbot is unhappy with the subject line not containing anything
useful, and not containing the subsystem name. Something like:

staging/lustre/llite: replace "unsigned" with "unsigned int"

> Replacing 'unsigned' with 'unsigned int'  in vvp_pgcache_id.

Remove double space, and reference function names like vvp_pgcache_id().
 
> Checkpath.pl passed.

"checkpatch.pl"

Cheers, Andreas

> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@...il.com>
> ---
> drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c b/drivers/staging/lustre/lustre/llite/vvp_dev.c
> index 12c129f7e..8d78755 100644
> --- a/drivers/staging/lustre/lustre/llite/vvp_dev.c
> +++ b/drivers/staging/lustre/lustre/llite/vvp_dev.c
> @@ -381,11 +381,10 @@ int cl_sb_fini(struct super_block *sb)
> #define PGC_DEPTH_SHIFT (32)
> 
> struct vvp_pgcache_id {
> -	unsigned		 vpi_bucket;
> -	unsigned		 vpi_depth;
> -	uint32_t		 vpi_index;
> -
> -	unsigned		 vpi_curdep;
> +	unsigned int		vpi_bucket;
> +	unsigned int		vpi_depth;
> +	uint32_t		vpi_index;
> +	unsigned int		vpi_curdep;
> 	struct lu_object_header *vpi_obj;
> };
> 
> -- 
> 2.7.4
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation