linux-kernel - Re: [PATCH v2] usb: gadget: legacy gadgets are optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8760jhze53.fsf@linux.intel.com>
Date:   Fri, 10 Mar 2017 11:15:20 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Romain Izard <romain.izard.pro@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Romain Izard <romain.izard.pro@...il.com>,
        "# 4 . 9+" <stable@...r.kernel.org>
Subject: Re: [PATCH v2] usb: gadget: legacy gadgets are optional


Hi,

Romain Izard <romain.izard.pro@...il.com> writes:
> With commit "usb: gadget: don't couple configfs to legacy gadgets"
> it is possible to build a modular kernel with both built-in configfs
> support and modular legacy gadget drivers.
>
> But when building a kernel without modules, it is also necessary to be
> able to build with configfs but without any legacy gadget driver.
>
> Mark the choice for legacy gadget drivers as optional.
>
> Fixes: bc49d1d17dcf ("usb: gadget: don't couple configfs to legacy gadgets")
> Cc: <stable@...r.kernel.org> # 4.9+

this is *NOT* a fix since this requirement didn't exist before.

> Signed-off-by: Romain Izard <romain.izard.pro@...il.com>
> ---
> changes in v2:
>  - Reword description
>
>  drivers/usb/gadget/Kconfig | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 8ad203296079..e157e9aa4f3d 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -212,7 +212,7 @@ config USB_F_TCM
>  # this first set of drivers all depend on bulk-capable hardware.
>  
>  config USB_CONFIGFS
> -	tristate "USB functions configurable through configfs"
> +	tristate "USB Gadget functions configurable through configfs"

unrelated change

>  	select USB_LIBCOMPOSITE
>  	help
>  	  A Linux USB "gadget" can be set up through configfs.
> @@ -458,8 +458,9 @@ config USB_CONFIGFS_F_TCM
>  	  UAS utilizes the USB 3.0 feature called streams support.
>  
>  choice
> -	tristate "USB Gadget Drivers"
> +	tristate "USB Gadget precomposed configurations"

unrelated change

>  	default USB_ETH
> +	optional
>  	help
>  	  A Linux "Gadget Driver" talks to the USB Peripheral Controller
>  	  driver through the abstract "gadget" API.  Some other operating
> @@ -476,6 +477,12 @@ choice
>  	  not be able work with that controller, or might need to implement
>  	  a less common variant of a device class protocol.
>  
> +	  The available choices each represent a single precomposed USB
> +	  gadget configuration. In the device model, each option contains
> +	  both the device instanciation as a child for a USB gadget
> +	  controller, and the relevant drivers for each function declared
> +	  by the device.

unrelated change

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)