linux-kernel - Re: [PATCH v2 net 6/8] net: bcmgenet: Power up the internal PHY before probing the MII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23787c1d-c897-eaa5-dda5-49607ac3617d@gmail.com>
Date:   Thu, 9 Mar 2017 17:44:36 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Doug Berger <opendmb@...il.com>
Cc:     pgynther@...gle.com, jaedon.shin@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net 6/8] net: bcmgenet: Power up the internal PHY
 before probing the MII

On 03/09/2017 04:58 PM, Doug Berger wrote:
> When using the internal PHY it must be powered up when the MII is probed
> or the PHY will not be detected.  Since the PHY is powered up at reset
> this has not been a problem.  However, when the kernel is restarted with
> kexec the PHY will likely be powered down when the kernel starts so it
> will not be detected and the Ethernet link will not be established.
> 
> This commit explicitly powers up the internal PHY when the GENET driver
> is probed to correct this behavior.
> 
> Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
> Signed-off-by: Doug Berger <opendmb@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian