linux-kernel - RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tw71xthj.fsf@linux.intel.com>
Date:   Fri, 10 Mar 2017 13:26:48 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Jerry Huang <jerry.huang@....com>,
        "robh+dt\@kernel.org" <robh+dt@...nel.org>,
        "mark.rutland\@arm.com" <mark.rutland@....com>,
        "catalin.marinas\@arm.com" <catalin.marinas@....com>
Cc:     "linux-usb\@vger.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree\@vger.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel\@lists.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Rajesh Bhagat <rajesh.bhagat@....com>
Subject: RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type


Hi,

Jerry Huang <jerry.huang@....com> writes:
>> >> --
>> >> 1.7.9.5
>> > Hi, Balbi and all guys,
>> > Any comment for these patches? Can they be accepted?
>> 
>> Rob had comments which you didn't reply yet. I cannot take this patchset
>> yet ;-)
>> 
> Balbi,
>
> I look into his mail again, which was based v3, and I replied it.
>
> He had different understanding for undefined length burst mode.
>
> It seems he think for this mode, just setting bit[0] (INCRBrstEna) and
> don't need to set other field.
>
> However, according to the DWC USB3.0 controller databook, when it is
> undefined length INCR burst mode, we still need to set one max burst
> type, such as INCR8, which means controller will use any length less
> than or equal to this INCR8.

Rob, do you agree with the patch now?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)