linux-kernel - Re: [PATCH 3.16 125/370] clk: renesas: mstp: Support 8-bit registers for r7s72100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUfhsepkcKFbkV3iM+3hUPvWy2t8dAp9A5sOcKwY5tH+g@mail.gmail.com>
Date:   Fri, 10 Mar 2017 13:10:36 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Ben Hutchings <ben@...adent.org.uk>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Chris Brandt <chris.brandt@...esas.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH 3.16 125/370] clk: renesas: mstp: Support 8-bit registers
 for r7s72100

Hi Ben,

On Fri, Mar 10, 2017 at 12:46 PM, Ben Hutchings <ben@...adent.org.uk> wrote:
> 3.16.42-rc1 review patch.  If anyone has any objections, please let me know.

No objections, but you also want

commit f59de563358eb9351b7f8f0ba2d3be2ebb70b93d
Author: Chris Brandt <chris.brandt@...esas.com>
Date:   Tue Feb 14 11:08:05 2017 -0500

    clk: renesas: mstp: ensure register writes complete

> ------------------
>
> From: Chris Brandt <chris.brandt@...esas.com>
>
> commit e2a33c34ddff22ee208d80abdd12b88a98d6cb60 upstream.
>
> The RZ/A1 is different than the other Renesas SOCs because the MSTP
> registers are 8-bit instead of 32-bit and if you try writing values as
> 32-bit nothing happens...meaning this driver never worked for r7s72100.
>
> Fixes: b6face404f38 ("ARM: shmobile: r7s72100: add essential clock nodes to dtsi")
> Signed-off-by: Chris Brandt <chris.brandt@...esas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> [bwh: Backported to 3.16: adjust filename]
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds