linux-kernel - Re: [PATCH v2] don't forget to call pd_online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2017 20:44:47 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Zhou Chengming <zhouchengming1@...wei.com>
Cc:     kbuild-all@...org, axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, miaoxie@...wei.com,
        zhouchengming1@...wei.com
Subject: Re: [PATCH v2] don't forget to call pd_online_fn when activate policy

Hi Zhou,

[auto build test ERROR on block/for-next]
[also build test ERROR on v4.11-rc1 next-20170309]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Zhou-Chengming/don-t-forget-to-call-pd_online_fn-when-activate-policy/20170310-140301
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: x86_64-rhel-7.2 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   block/blk-cgroup.c: In function 'blkcg_activate_policy':
>> block/blk-cgroup.c:1261:14: error: incompatible type for argument 1 of 'spin_lock'
       spin_lock(blkg->blkcg->lock);
                 ^~~~
   In file included from include/linux/rcupdate.h:38:0,
                    from include/linux/rculist.h:10,
                    from include/linux/pid.h:4,
                    from include/linux/sched.h:13,
                    from include/linux/ioprio.h:4,
                    from block/blk-cgroup.c:17:
   include/linux/spinlock.h:297:29: note: expected 'spinlock_t * {aka struct spinlock *}' but argument is of type 'spinlock_t {aka struct spinlock}'
    static __always_inline void spin_lock(spinlock_t *lock)
                                ^~~~~~~~~
>> block/blk-cgroup.c:1263:16: error: incompatible type for argument 1 of 'spin_unlock'
       spin_unlock(blkg->blkcg->lock);
                   ^~~~
   In file included from include/linux/rcupdate.h:38:0,
                    from include/linux/rculist.h:10,
                    from include/linux/pid.h:4,
                    from include/linux/sched.h:13,
                    from include/linux/ioprio.h:4,
                    from block/blk-cgroup.c:17:
   include/linux/spinlock.h:337:29: note: expected 'spinlock_t * {aka struct spinlock *}' but argument is of type 'spinlock_t {aka struct spinlock}'
    static __always_inline void spin_unlock(spinlock_t *lock)
                                ^~~~~~~~~~~

vim +/spin_lock +1261 block/blk-cgroup.c

  1255			pd->blkg = blkg;
  1256			pd->plid = pol->plid;
  1257			if (pol->pd_init_fn)
  1258				pol->pd_init_fn(pd);
  1259	
  1260			if (pol->pd_online_fn) {
> 1261				spin_lock(blkg->blkcg->lock);
  1262				pol->pd_online_fn(pd);
> 1263				spin_unlock(blkg->blkcg->lock);
  1264			}
  1265		}
  1266	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (38803 bytes)