linux-kernel - Re: [PATCH RFC,v2] tpm_crb: request and relinquish locality 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170311123809.pa6gdh3tbdvcod55@intel.com>
Date:   Sat, 11 Mar 2017 14:38:09 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     tpmdd-devel@...ts.sourceforge.net
Cc:     linux-security-module@...r.kernel.org,
        Jerry Snitselaar <jsnitsel@...hat.com>, gang.wei@...el.com,
        Peter Huewe <peterhuewe@....de>,
        Marcel Selhorst <tpmdd@...horst.net>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC,v2] tpm_crb: request and relinquish locality 0

On Sat, Mar 11, 2017 at 12:55:43PM +0200, Jarkko Sakkinen wrote:
> On Sat, Mar 11, 2017 at 12:53:36PM +0200, Jarkko Sakkinen wrote:
> > Added two new callbacks to struct tpm_class_ops:
> > 
> > - request_locality
> > - relinquish_locality
> > 
> > These are called before sending and receiving data from the TPM.
> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > ---
> > This not yet v2 of this patch. I'm checking that this is what needs to be done
> > for tpm_tis_core before I go through testing etc. Thank you.
> 
> And apparently I did not amend tpm-interface.c change :( Anyway, I'm
> merely sanity checking that I'm doing the right thing.

If check_locality fails request_locality returns locality number
but it's not used for anything. Would it be OK to change it to
just return -EBUSY in this case?

/Jarkko