linux-kernel - Re: [PATCH] Staging: iio: return expression instead of return ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0634a5c4-44e3-bf39-22b8-9e028c5412a8@kernel.org>
Date:   Sat, 11 Mar 2017 18:25:24 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Bo Yu <tsu.yubo@...il.com>, Clausen <lars@...afoo.de>,
        Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hennerich <Michael.Hennerich@...log.com>,
        Knaack <knaack.h@....de>, Meerwald-Stadler <pmeerw@...erw.net>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH] Staging: iio: return expression instead of return ret

On 10/03/17 03:57, Bo Yu wrote:
> The following Coccinelle script was used to detect this:
> 
> @@
> local idexpression ret;
> expression e;
> @@
> 
> -ret =
> +return
>       e;
> -return ret;

A bit of fuzz on this one. Presumably things moving around in other recent
changes.

Anyhow, applied to the togreg branch of iio.git. Will push out as testing
shortly for the autobuilders to play with it.

Thanks,

Jonathan
> 
> Signed-off-by: Bo YU <tsu.yubo@...il.com>
> ---
>   drivers/staging/iio/meter/ade7754.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/meter/ade7754.c b/drivers/staging/iio/meter/ade7754.c
> index 024463a11c47..19f8cb144768 100644
> --- a/drivers/staging/iio/meter/ade7754.c
> +++ b/drivers/staging/iio/meter/ade7754.c
> @@ -349,9 +349,8 @@ static int ade7754_set_irq(struct device *dev, bool enable)
>       else
>           irqen &= ~BIT(14);
> 
> -    ret = ade7754_spi_write_reg_16(dev, ADE7754_IRQEN, irqen);
> +    return ade7754_spi_write_reg_16(dev, ADE7754_IRQEN, irqen);
> 
> -    return ret;
>   }
> 
>   /* Power down the device */
> -- 
> 1.7.10.4
>